adoroszlai commented on code in PR #8383:
URL: https://github.com/apache/ozone/pull/8383#discussion_r2084595320


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java:
##########
@@ -46,9 +45,6 @@
 public final class OzoneAclUtil {
   static final Logger LOG = LoggerFactory.getLogger(OzoneAclUtil.class);
 
-  private static ACLType[] userRights;

Review Comment:
   Thanks @ChenSammi for the review.  Collections object is not short-lived, 
because `OzoneManager` keeps a single instance of `OmConfig`, which uses the 
`MemoizedSupplier` to remember the `List<ACLType` collection.  Only the result 
of `toArray()` is short-lived.  I'll update the PR to avoid that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to