fapifta commented on a change in pull request #2083:
URL: https://github.com/apache/ozone/pull/2083#discussion_r616074226
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -145,12 +145,14 @@ public StatusAndMessages finalize(String upgradeClientID,
T id)
@Override
public synchronized StatusAndMessages reportStatus(
- String upgradeClientID, boolean takeover
+ String upgradeClientID, boolean takeover, boolean readonly
) throws UpgradeException {
if (takeover) {
clientID = upgradeClientID;
}
- assertClientId(upgradeClientID);
+ if (!readonly) {
+ assertClientId(upgradeClientID);
Review comment:
Oh, one more thing came to my mind... We do not have any tests, that
catches this behaviour, or if we do, it does not catch this problem. Should we
have one? I am not sure about it, as the behaviour depends on concurrency, and
timing of calls, so it might be more complicated/flaky than useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
