swamirishi commented on code in PR #8141:
URL: https://github.com/apache/ozone/pull/8141#discussion_r2093793989
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java:
##########
@@ -220,6 +246,8 @@ void cleanup() {
LOG.debug("Closing SnapshotId {}. It is not being referenced
anymore.", k);
// Close the instance, which also closes its DB handle.
try {
+ compactSnapshotDB(v.get());
Review Comment:
@jojochuang @smengcl This can block other read operations. Let us perform
the snapshot compaction while we still allow reads to go through. Compactions
shouldn't block active snapshot operations both background services and active
user reads. @peterxcli please write a test case for this as well so that we
don't inadvertently block any snapshot operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
