siddhantsangwan commented on code in PR #8492:
URL: https://github.com/apache/ozone/pull/8492#discussion_r2113436394
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -335,7 +343,15 @@ && getMissingContainerSet().contains(containerID)) {
// Small performance optimization. We check if the operation is of type
// write before trying to send CloseContainerAction.
if (!HddsUtils.isReadOnly(msg)) {
- sendCloseContainerActionIfNeeded(container);
+ boolean isFull = isVolumeFull(container);
+ sendCloseContainerActionIfNeeded(container, isFull);
+ if (isFull) {
+ try {
+ handleFullVolume(container.getContainerData().getVolume());
+ } catch (StorageContainerException e) {
+ ContainerUtils.logAndReturnError(LOG, e, msg);
Review Comment:
Good catch, but I'm not sure. There was an exception in getting the node
report, but does that mean we should fail the write? Maybe we should still let
the write continue here. Otherwise because of an intermittent or not severe
exception we could keep on failing writes. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
