errose28 commented on PR #8523: URL: https://github.com/apache/ozone/pull/8523#issuecomment-2924057955
> If some field has been removed that a used was getting from ozone admin datanode list --json, then now they may have to run that, and then run datanode info for each DN, which could be slow. Most of the fields I proposed removing in the Jira are either: - duplicate information - information internal to ozone for testing - information that SCM was not populating, which was therefore incorrect. Although removing these is technically incompatible by our definition, I would consider their inclusion to be bugs in the first place making this a bug fix. We have used similar reasoning to "break compatibility" by adding json lists to list output commands. cc @adoroszlai if you have any thoughts on this as well. There are two proposed changes that fall outside of this: - Grouping the topology information into one object - Removing the port information (saved for `ozone admin datanode info`) If there are more concerns about that part of the change we can look at them in a separate Jira/PR, but IMO `ozone admin datanode list` is not very usable with the verbose port list taking up half the object (after removing other duplicate content), and the mixed placement of topology information is difficult to make sense out of. I don't see much use case for aggregating ports across all nodes in one shot either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
