peterxcli commented on code in PR #8610:
URL: https://github.com/apache/ozone/pull/8610#discussion_r2144477524
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDiskBalancer.java:
##########
@@ -58,8 +64,8 @@ public class TestDiskBalancer {
private static OzoneConfiguration ozoneConf;
private static DiskBalancerManager diskBalancerManager;
- @BeforeAll
- public static void setup() throws Exception {
+ @BeforeEach
Review Comment:
This would start cluster for each test case, which is time-consuming for ci.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDiskBalancer.java:
##########
@@ -130,7 +136,43 @@ public void testDiskBalancerStopAfterEven() throws
IOException,
}
@Test
- public void testDatanodeDiskBalancerStatus() throws IOException {
- // TODO: Test status command with datanodes in balancing
+ public void testDatanodeDiskBalancerStatus() throws IOException,
InterruptedException, TimeoutException {
Review Comment:
Consider to adjust the execution order to MAX or bring the decomissioned dn
back at the end of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
