sumitagrawl commented on code in PR #8365:
URL: https://github.com/apache/ozone/pull/8365#discussion_r2153683267
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -405,6 +408,38 @@ public long getFreeSpaceToSpare(long volumeCapacity) {
return getDatanodeConfig().getMinFreeSpace(volumeCapacity);
}
+ @Override
+ public void setGatherContainerUsages(Function<HddsVolume, Long>
gatherContainerUsages) {
+ this.gatherContainerUsages = gatherContainerUsages;
+ }
+
+ @Override
+ protected long containerUsedSpace() {
+ return gatherContainerUsages.apply(this);
+ }
+
+ @Override
+ public File getContainerDirsPath() {
+ if (getStorageState() != VolumeState.NORMAL) {
+ return null;
+ }
+ File hddsVolumeRootDir = getHddsRootDir();
+ //filtering storage directory
+ File[] storageDirs = hddsVolumeRootDir.listFiles(File::isDirectory);
+ if (storageDirs == null) {
+ LOG.error("IO error for the volume {}, directory not found",
hddsVolumeRootDir);
+ return null;
+ }
+ File clusterIDDir = new File(hddsVolumeRootDir, getClusterID());
+ if (storageDirs.length == 1 && !clusterIDDir.exists()) {
+ // If this volume was formatted pre SCM HA, this will be the SCM ID.
+ // A cluster ID symlink will exist in this case only if this cluster is
finalized for SCM HA.
+ // If the volume was formatted post SCM HA, this will be the cluster ID.
+ clusterIDDir = storageDirs[0];
+ }
+ return new File(clusterIDDir, Storage.STORAGE_DIR_CURRENT);
Review Comment:
volume will be marked failed if it does not exist. This is done at
org.apache.hadoop.ozone.container.ozoneimpl.ContainerReader#readVolume while
loading volume and container set.
In begning of this method, we check volume to be NORMAL state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
