adoroszlai commented on code in PR #8683:
URL: https://github.com/apache/ozone/pull/8683#discussion_r2164440067
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/PrefixParser.java:
##########
@@ -182,17 +182,13 @@ public BucketLayout getBucketLayout() {
return BucketLayout.FILE_SYSTEM_OPTIMIZED;
}
- private void dumpTableInfo(Types type,
+ private <T extends WithParentObjectId> void dumpTableInfo(Types type,
org.apache.hadoop.fs.Path effectivePath,
- Table<String, ? extends WithParentObjectId> table,
+ Table<String, T> table,
long volumeId, long bucketId, long lastObjectId)
throws IOException {
- MetadataKeyFilters.KeyPrefixFilter filter = getPrefixFilter(
- volumeId, bucketId, lastObjectId);
-
- List<? extends KeyValue
- <String, ? extends WithParentObjectId>> infoList =
- table.getRangeKVs(null, 1000, null, filter);
+ final KeyPrefixFilter filter = getPrefixFilter(volumeId, bucketId,
lastObjectId);
+ final List<KeyValue<String, T>> infoList = table.getRangeKVs(null, 1000,
null, filter, false);
for (KeyValue<String, ? extends WithParentObjectId> info :infoList) {
Review Comment:
nit: this can also be replaced with `T`.
```suggestion
for (KeyValue<String, T> info : infoList) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
