adoroszlai commented on code in PR #8702:
URL: https://github.com/apache/ozone/pull/8702#discussion_r2184492039


##########
hadoop-ozone/dist/src/main/smoketest/ozone-lib/shell.robot:
##########
@@ -122,3 +122,8 @@ Verify EC Replication Config
                    Should Match Regexp      ${result}       ^(?m)${data}$
                    Should Match Regexp      ${result}       ^(?m)${parity}$
                    Should Match Regexp      ${result}       ^(?m)${chunksize}$
+
+Get bucket owner
+    [arguments]    ${bucket}
+    ${owner} =     Execute     ozone sh bucket info /s3v/${bucket} | jq -r 
'.owner'
+    [return]       ${owner}

Review Comment:
   Sorry, I just realized that:
   
   - `/s3v` is hard-coded
   - more importantly, this only works with Ozone, not with AWS S3
   
   The latter is important when cross-checking our S3 tests with AWS:
   
   
https://github.com/apache/ozone/blob/1ca2f2a2aa2b9dc28492dd8cbff7e578f3d7935c/hadoop-ozone/dist/src/main/smoketest/s3/s3_compatbility_check.sh#L20-L21
   
   Can you please move it back to `commonawslib.robot`, and implement it using 
`Execute AWSS3APICli`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to