jojochuang commented on code in PR #8678:
URL: https://github.com/apache/ozone/pull/8678#discussion_r2192842139
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -255,6 +257,21 @@ public void writeDbDataToStream(HttpServletRequest
request, OutputStream destina
hardLinkFileMap, getCompactionLogDir());
writeDBToArchive(sstFilesToExclude, tmpSstBackupDir,
maxTotalSstSize, archiveOutputStream, tmpdir,
hardLinkFileMap, getSstBackupDir());
+
Review Comment:
please consider extracting the entire checkpoint transfer last step to a new
method.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java:
##########
@@ -139,6 +139,7 @@ public void invalidate(UUID key) {
LOG.warn("SnapshotId: '{}' does not exist in snapshot cache.", k);
} else {
try {
+ v.get().getMetadataManager().getStore().flushDB();
Review Comment:
is this necessary?
https://javadoc.io/doc/org.rocksdb/rocksdbjni/6.8.1/org/rocksdb/Options.html#avoidFlushDuringShutdown()
By default RocksDB will flush all memtables on DB close if there are
unpersisted data (i.e. with WAL disabled) T
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java:
##########
@@ -278,13 +276,146 @@ void testContentsOfTarballWithSnapshot() throws
Exception {
assertFalse(hardlinkFilePath.toFile().exists());
}
+ @Test
Review Comment:
```suggestion
/**
* Verifies that a manually added entry to the snapshot's delete table
* is persisted and can be retrieved from snapshot db loaded from OM DB
checkpoint.
*/
@Test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
