errose28 commented on code in PR #8448: URL: https://github.com/apache/ozone/pull/8448#discussion_r2214420083
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeScannerMetrics.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.volume; + +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; + +/** + * This class captures the Storage Volume Scanner Metrics. + **/ +@InterfaceAudience.Private +@Metrics(about = "Storage Volume Scanner Metrics", context = "dfs") +public class StorageVolumeScannerMetrics { + public static final String SOURCE_NAME = StorageVolumeScannerMetrics.class.getSimpleName(); + + @Metric("number of volumes scanned in the last iteration") + private MutableGaugeLong numVolumesScannedInLastIteration; + + @Metric("number of iterations the volume scanner has completed since the last restart") + private MutableCounterLong numScanIterations; + + @Metric("number of data volumes scanned since the last restart") Review Comment: ```suggestion @Metric("number of data volume scans since the last restart") ``` ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeScannerMetrics.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.volume; + +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; + +/** + * This class captures the Storage Volume Scanner Metrics. + **/ +@InterfaceAudience.Private +@Metrics(about = "Storage Volume Scanner Metrics", context = "dfs") +public class StorageVolumeScannerMetrics { + public static final String SOURCE_NAME = StorageVolumeScannerMetrics.class.getSimpleName(); + + @Metric("number of volumes scanned in the last iteration") + private MutableGaugeLong numVolumesScannedInLastIteration; + + @Metric("number of iterations the volume scanner has completed since the last restart") + private MutableCounterLong numScanIterations; + + @Metric("number of data volumes scanned since the last restart") + private MutableCounterLong numDataVolumeScans; + + @Metric("number of metadata volumes scanned since the last restart") Review Comment: ```suggestion @Metric("number of metadata volume scans since the last restart") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
