ermahesh commented on code in PR #8848:
URL: https://github.com/apache/ozone/pull/8848#discussion_r2229664643


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCommitPartRequest.java:
##########
@@ -220,16 +224,45 @@ public OMClientResponse 
validateAndUpdateCache(OzoneManager ozoneManager, Execut
 
       omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);
 
+      // This map should contain maximum of two entries
+      // 1. Overwritten part
+      // 2. Uncommitted pseudo part key
+      Map<String, RepeatedOmKeyInfo> keyVersionsToDeleteMap = null;
+
       long correctedSpace = omKeyInfo.getReplicatedSize();
       if (null != oldPartKeyInfo) {
         OmKeyInfo partKeyToBeDeleted =
             OmKeyInfo.getFromProtobuf(oldPartKeyInfo.getPartKeyInfo());
         correctedSpace -= partKeyToBeDeleted.getReplicatedSize();
+        RepeatedOmKeyInfo oldVerKeyInfo = 
getOldVersionsToCleanUp(partKeyToBeDeleted, trxnLogIndex);

Review Comment:
   Minor : The validateAndUpdateCache method in 
S3MultipartUploadCommitPartRequest is becoming long and complex. We should try 
to refactor this method



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCommitPartRequest.java:
##########
@@ -220,16 +224,45 @@ public OMClientResponse 
validateAndUpdateCache(OzoneManager ozoneManager, Execut
 
       omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);
 
+      // This map should contain maximum of two entries
+      // 1. Overwritten part
+      // 2. Uncommitted pseudo part key
+      Map<String, RepeatedOmKeyInfo> keyVersionsToDeleteMap = null;
+
       long correctedSpace = omKeyInfo.getReplicatedSize();
       if (null != oldPartKeyInfo) {
         OmKeyInfo partKeyToBeDeleted =
             OmKeyInfo.getFromProtobuf(oldPartKeyInfo.getPartKeyInfo());
         correctedSpace -= partKeyToBeDeleted.getReplicatedSize();
+        RepeatedOmKeyInfo oldVerKeyInfo = 
getOldVersionsToCleanUp(partKeyToBeDeleted, trxnLogIndex);

Review Comment:
   We can create a new 
[HDDS-13503](https://issues.apache.org/jira/browse/HDDS-13503) issue for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to