adoroszlai commented on code in PR #8677:
URL: https://github.com/apache/ozone/pull/8677#discussion_r2244523932
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestContainerOperations.java:
##########
@@ -188,19 +188,16 @@ public void testDatanodeUsageInfoCompatibility() throws
IOException {
@Test
public void testDatanodeUsageInfoContainerCount() throws Exception {
- List<? extends DatanodeDetails> dnList =
cluster().getStorageContainerManager()
- .getScmNodeManager()
- .getAllNodes();
+ NodeManager nodeManager =
cluster().getStorageContainerManager().getScmNodeManager();
+ List<? extends DatanodeDetails> dnList = nodeManager.getAllNodes();
for (DatanodeDetails dn : dnList) {
- final int expected =
cluster().getStorageContainerManager().getScmNodeManager().getContainers(dn).size();
-
List<HddsProtos.DatanodeUsageInfoProto> usageInfoList =
storageClient.getDatanodeUsageInfo(
dn.getIpAddress(), dn.getUuidString());
assertEquals(1, usageInfoList.size());
- assertEquals(expected, usageInfoList.get(0).getContainerCount());
+ assertEquals(nodeManager.getContainers(dn).size(),
usageInfoList.get(0).getContainerCount());
Review Comment:
This change in `TestContainerOperations` seems completely unrelated to the
rest of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
