adoroszlai commented on code in PR #8910:
URL: https://github.com/apache/ozone/pull/8910#discussion_r2259078691
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java:
##########
@@ -131,10 +131,12 @@ public void execute(ScmClient scmClient) throws
IOException {
if (response.getStart()) {
System.out.println("Container Balancer started successfully.");
} else {
- System.out.println("Failed to start Container Balancer.");
+ String errMsg = "Failed to start Container Balancer.";
+ System.out.println(errMsg);
if (response.hasMessage()) {
System.out.printf("Failure reason: %s", response.getMessage());
Review Comment:
- This should also print to `System.err`.
- Please add newline (`%n`) at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
