errose28 commented on PR #8893: URL: https://github.com/apache/ozone/pull/8893#issuecomment-3165501589
In this PR, let's also update [this location](https://github.com/apache/ozone/blob/3c4b3bec36e7f8c8b2bb4793d2e1088b60fc148f/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java#L314) which gets triggered when the container file cannot be updated. We should do an on-demand container scan first, and only a volume scan if that fails. However, we don't want to trigger the on-demand container scan in this exact spot in case this is being called to mark the container unhealthy, or it will get stuck in a loop. Instead we probably want to trigger it [here](https://github.com/apache/ozone/blob/3c4b3bec36e7f8c8b2bb4793d2e1088b60fc148f/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java#L487). Note that if a container scan fails due to permission errors, the result will only be kept in memory. Persistence will fail since we don't have permission to update the file, but that is desirable since permissions can be restored on restart. Let's add a comment explaining that in this scan location as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
