sumitagrawl commented on code in PR #8887:
URL: https://github.com/apache/ozone/pull/8887#discussion_r2289776297
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java:
##########
@@ -235,6 +238,10 @@ public void verifyAndFixupContainerData(ContainerData
containerData)
return;
}
+ if (!isMatchedLastLoadedECContainer(kvContainer,
containerSet.getContainerMetadataStore())) {
+ return;
Review Comment:
As discussed, current addContainer mechanism as implemented to add to DB is
not correct, we need change that separately to have rework on previous
requirement. So concluded to go with current mechanism.
Solution to go with your comment:
- Need delay addContainer() after all container is loaded in another
container Map.
- The while deciding to add to ContainerSet once decision is made
This is refactoring of existing flow of loading container.
May be if there is a concern to allow load of different container is some
error scenario of different index, may be we need close this PR till that is
completed.
But I do not find any scenario for such thing in healthy dns running.
@swamirishi Share your suggestion if need continue this PR or hold till
refactor is completed. IMO, this kind of scenario need manual intervention, but
data is available if required manual recover as discussed also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
