errose28 commented on code in PR #9010:
URL: https://github.com/apache/ozone/pull/9010#discussion_r2334570908
##########
hadoop-ozone/ozone-manager/pom.xml:
##########
@@ -453,17 +453,24 @@
<groupId>dev.aspectj</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>${maven.compiler.source}</source>
+ <target>${maven.compiler.target}</target>
Review Comment:
The maven-compiler-plugin will automatically populate
`maven.compiler.{source,target}` with `maven.compiler.release` for jdk8, which
is why we could remove the `java8` profile. We should probably use
`maven.compiler.release` here and on line 473 so we don't need to depend on
this outside the java 8 context.
From the
[docs](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html):
> The --release option is not supported using JDK 8. However, since Compiler
plugin version 3.13.0 you can use the release property also on JDK 8. The
plugin will convert it to source and target automatically.
We are using maven compiler plugin [version
3.14.0](https://github.com/apache/ozone/blob/b7df320810c0d01d3bab4f6299b464a2ada44507/pom.xml#L147)
##########
pom.xml:
##########
@@ -33,6 +33,8 @@
<aopalliance.version>1.0</aopalliance.version>
<apache-rat-plugin.version>0.16.1</apache-rat-plugin.version>
<aspectj-plugin.version>1.14.1</aspectj-plugin.version>
+ <aspectj.java11.version>1.9.20</aspectj.java11.version>
+ <aspectj.java21.version>1.9.24</aspectj.java21.version>
<aspectj.version>1.9.7</aspectj.version>
Review Comment:
Let's add a comment that this is the version that gets used when building
with java 8 only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
