devabhishekpal commented on code in PR #9033:
URL: https://github.com/apache/ozone/pull/9033#discussion_r2349558247
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/types/overview.types.ts:
##########
@@ -33,29 +33,15 @@ export type ClusterStateResponse = {
omServiceId: string;
}
-export type OverviewState = {
- loading: boolean;
- datanodes: string;
- pipelines: number;
- containers: number;
- volumes: number;
- buckets: number;
- keys: number;
- missingContainersCount: number;
- lastRefreshed: number;
- lastUpdatedOMDBDelta: number;
- lastUpdatedOMDBFull: number;
- omStatus: string;
- openContainers: number;
- deletedContainers: number;
- openSummarytotalUnrepSize: number;
- openSummarytotalRepSize: number;
- openSummarytotalOpenKeys: number;
- deletePendingSummarytotalUnrepSize: number;
- deletePendingSummarytotalRepSize: number;
- deletePendingSummarytotalDeletedKeys: number;
- scmServiceId: string;
- omServiceId: string;
+export type TaskStatus = {
+ taskName: string;
Review Comment:
You are absolutely correct here, we should be using strict types for safety
since TS is supposed to be used for this kind of situation.
Addressed this in the latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
