Copilot commented on code in PR #8906:
URL: https://github.com/apache/ozone/pull/8906#discussion_r2392961649
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotMoveTableKeysRequest.java:
##########
@@ -49,6 +55,16 @@
* This is an OM internal request. Does not need @RequireSnapshotFeatureState.
*/
public class OMSnapshotMoveTableKeysRequest extends OMClientRequest {
+ private static final AuditLogger AUDIT = new
AuditLogger(AuditLoggerType.OMSYSTEMLOGGER);
+ private static final String AUDIT_PARAM_FROM_SNAPSHOT_TABLE_KEY =
"fromSnapshotTableKey";
+ private static final String AUDIT_PARAM_TO_SNAPSHOT_TABLE_KEY_OR_AOS =
"toSnapshotTableKeyOrAOS";
+ private static final String AUDIT_PARAM_DEL_KEYS_MOVED = "deletedKeysMoved";
+ private static final String AUDIT_PARAM_RENAMED_KEYS_MOVED =
"renamedKeysMoved";
+ private static final String AUDIT_PARAM_DEL_DIRS_MOVED = "deletdDirsMoved";
Review Comment:
The constant name contains a typo: 'deletdDirsMoved' should be
'deletedDirsMoved'.
```suggestion
private static final String AUDIT_PARAM_DEL_DIRS_MOVED =
"deletedDirsMoved";
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotSetPropertyRequest.java:
##########
@@ -118,22 +148,33 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, Execut
});
if (updatedSnapInfo == null) {
LOG.error("Snapshot: '{}' doesn't not exist in snapshot table.",
snapshotKey);
- throw new OMException("Snapshot: '{}' doesn't not exist in snapshot
table." + snapshotKey
+ OMException e = new OMException("Snapshot: '{}' doesn't not exist in
snapshot table." + snapshotKey
Review Comment:
Double negative in error message: 'doesn't not exist' should be 'doesn't
exist' or 'does not exist'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
