adoroszlai commented on code in PR #9084:
URL: https://github.com/apache/ozone/pull/9084#discussion_r2394782027
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1438,6 +1438,14 @@ message PurgeDirectoriesRequest {
optional string snapshotTableKey = 2;
// previous snapshotID can also be null & this field would be absent in
older requests.
optional NullableUUID expectedPreviousSnapshotID = 3;
+ repeated BucketNameInfo bucketNameInfos = 4;
+}
+
+message BucketNameInfo {
+ required uint64 volumeId = 1;
+ required uint64 bucketId = 2;
+ required string volumeName = 3;
+ required string bucketName = 4;
Review Comment:
Please don't add `required` members.
https://protobuf.dev/programming-guides/style/#required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
