Attila Doroszlai created HDDS-13731:
---------------------------------------
Summary: Extra parent dir appeared in CI artifacts
Key: HDDS-13731
URL: https://issues.apache.org/jira/browse/HDDS-13731
Project: Apache Ozone
Issue Type: Sub-task
Components: CI
Affects Versions: 2.1.0
Reporter: Attila Doroszlai
Assignee: Attila Doroszlai
HDDS-13144 introduced a new CI check ({{javadoc}}) for aggregate API docs.
However, it does not follow the same conventions as other checks.
1. Results are stored in {{target/reports/apidocs}} instead of
{{target/javadoc}}. To account for that, all checks attempt to include this
directory in their artifact, although it only exists for {{javadoc}}:
{code:title=https://github.com/apache/ozone/blob/f4c8a12edb0d5256cbbcc5d11fd2396c79470b15/.github/workflows/check.yml#L252-L260}
- name: Archive build results
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: ${{ (inputs.split && format('{0}-{1}', inputs.script,
inputs.split)) || inputs.script }}
path: |
target/${{ inputs.script }}
target/reports/apidocs
continue-on-error: true
{code}
This introduces an unnecessary parent directory for all other checks:
{code:title=before}
$ unzip -t build.zip
Archive: build.zip
testing: failures OK
testing: output.log OK
testing: summary.txt OK
No errors detected in compressed data of build.zip.
{code}
{code:title=after}
$ unzip -t build.zip
Archive: build.zip
testing: build/failures OK
testing: build/output.log OK
testing: build/summary.txt OK
No errors detected in compressed data of build.zip.
{code}
2. {{javadoc}}'s artifact does not include the standard {{summary.txt}},
{{failures}} and {{output.log}} files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
