sarvekshayr commented on code in PR #9091:
URL: https://github.com/apache/ozone/pull/9091#discussion_r2405015559
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java:
##########
@@ -254,6 +258,18 @@ public List<DatanodeAdminError>
updateDiskBalancerConfiguration(
return errors;
}
+ private boolean isDatanodeInOptimalState(DatanodeDetails dn,
Review Comment:
Could you add a javadoc for `isDatanodeInOptimalState` method and mention
which states are considered as optimal?
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerCommonOptions.java:
##########
@@ -57,7 +57,8 @@ public boolean check() {
}
public String getHostString() {
- return isAllHosts() ? "All datanodes" : String.join("\n", getDatanodes());
+ return isAllHosts() ? "All datanodes which are IN_SERVICE and HEALTHY."
+ : String.join("\n", getDatanodes());
}
Review Comment:
This split log doesn't convey the message clearly -
```
bash-5.1$ ozone admin datanode diskbalancer start -t 0.0001 -a
Start DiskBalancer on datanode(s):
All datanodes which are IN_SERVICE and HEALTHY.
```
How about this?
```
bash-5.1$ ozone admin datanode diskbalancer start -t 0.0001 -a
Starting DiskBalancer on datanode(s) which are IN_SERVICE and HEALTHY.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
