priyeshkaratha commented on PR #9147: URL: https://github.com/apache/ozone/pull/9147#issuecomment-3405130628
Hi @sarvekshayr, thanks for working on this. The overall code looks good to me. I have a few suggestions: I noticed that two new maps have been introduced — the first one’s size will be proportional to the number of containers. It might be helpful to include a note in the PR about the expected memory overhead. For example, with around 900k containers and 50 volumes, the additional heap usage could be roughly 50–70 MB. From my understanding, since the computation primarily happens during container additions, the performance impact should be minimal. However, it would be good to document these details in the PR description, covering both the heap memory footprint and performance considerations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
