siddhantsangwan commented on code in PR #9047:
URL: https://github.com/apache/ozone/pull/9047#discussion_r2378504303
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -387,18 +397,22 @@ private static void blockTillTaskStop(Thread
balancingThread) {
*/
public void stopBalancer()
throws IOException, IllegalContainerBalancerStateException {
- Thread balancingThread;
+ Thread balancingThread = null;
lock.lock();
try {
- validateState(true);
+ validateEligibility();
Review Comment:
No, because the in-memory state of being stopped may not be the correct
state as I've described in the jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
