ChenSammi commented on code in PR #9036:
URL: https://github.com/apache/ozone/pull/9036#discussion_r2431095094
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -645,12 +645,16 @@ private void updateMetaData(KeyValueContainerData
containerData,
// update pending deletion blocks count and delete transaction ID in
// in-memory container status
- long pendingBytes = containerData.getBlockPendingDeletionBytes() +
delTX.getTotalBlockSize();
+ long pendingBytes = containerData.getBlockPendingDeletionBytes();
+ if (delTX.hasTotalBlockSize()) {
Review Comment:
Priyesh, we also need to
a. add the If
(VersionedDatanodeFeatures.isFinalized(HDDSLayoutFeature.DATA_DISTRIBUTION))
check in
resetPendingDeleteBlockCount()
b. do the null check in KeyValueContainerMetadataInspector#getDBMetadataJson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
