Copilot commented on code in PR #9109:
URL: https://github.com/apache/ozone/pull/9109#discussion_r2408934797
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/ListLimitOptions.java:
##########
@@ -49,7 +49,7 @@ static class ExclusiveGroup {
private int limit;
@CommandLine.Option(names = {"--all", "-a"},
- description = "List all results",
+ description = "List all results (without pagination limit)",
defaultValue = "false")
Review Comment:
[nitpick] For picocli boolean flags, the default is false by default;
setting defaultValue = "false" is redundant and can be removed to reduce noise.
```suggestion
description = "List all results (without pagination limit)")
```
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/ListLimitOptions.java:
##########
@@ -49,7 +49,7 @@ static class ExclusiveGroup {
private int limit;
@CommandLine.Option(names = {"--all", "-a"},
- description = "List all results",
+ description = "List all results (without pagination limit)",
Review Comment:
[nitpick] Consider making the relationship to -l/--limit explicit to avoid
ambiguity; for example: description = "List all results (ignores -l/--limit)".
This ties the help text directly to the mutually exclusive option shown in the
usage.
```suggestion
description = "List all results (ignores -l/--length)",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
