hevinhsu commented on code in PR #9110: URL: https://github.com/apache/ozone/pull/9110#discussion_r2415497812
########## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketEndpointRefactoredSimple.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.endpoint; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import java.io.IOException; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.client.OzoneClientStub; +import org.apache.hadoop.ozone.s3.RequestIdentifier; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; +import org.apache.hadoop.ozone.s3.exception.S3ErrorTable; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +/** + * Simple unit tests for the refactored BucketEndpoint methods. + */ +public class TestBucketEndpointRefactoredSimple { + + private BucketEndpoint bucketEndpoint; + + @BeforeEach + public void setUp() throws IOException { + bucketEndpoint = new BucketEndpoint(); + OzoneClientStub client = new OzoneClientStub(); + + bucketEndpoint.setClient(client); + bucketEndpoint.setRequestIdentifier(new RequestIdentifier()); + bucketEndpoint.setOzoneConfiguration(new OzoneConfiguration()); + bucketEndpoint.init(); Review Comment: Maybe we can use a builder to simplify the endpoint creation: ```suggestion OzoneClientStub client = new OzoneClientStub(); bbucketEndpoint = EndpointBuilder.newBucketEndpointBuilder() .setClient(client) .build(); ``` ########## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketEndpointRefactoredSimple.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.endpoint; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import java.io.IOException; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.client.OzoneClientStub; +import org.apache.hadoop.ozone.s3.RequestIdentifier; +import org.apache.hadoop.ozone.s3.exception.OS3Exception; +import org.apache.hadoop.ozone.s3.exception.S3ErrorTable; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +/** + * Simple unit tests for the refactored BucketEndpoint methods. + */ +public class TestBucketEndpointRefactoredSimple { + + private BucketEndpoint bucketEndpoint; + + @BeforeEach + public void setUp() throws IOException { + bucketEndpoint = new BucketEndpoint(); + OzoneClientStub client = new OzoneClientStub(); + + bucketEndpoint.setClient(client); + bucketEndpoint.setRequestIdentifier(new RequestIdentifier()); + bucketEndpoint.setOzoneConfiguration(new OzoneConfiguration()); + bucketEndpoint.init(); + + // Create a test bucket + client.getObjectStore().createS3Bucket("test-bucket"); Review Comment: Looks like all test cases use the same bucketName. Maybe we can extract it into a shared variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
