Copilot commented on code in PR #9108:
URL: https://github.com/apache/ozone/pull/9108#discussion_r2408772095
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java:
##########
@@ -134,9 +134,13 @@ public void handleRequestFailure(OzoneManager
ozoneManager) {
* Validate the OMRequest and update the cache.
* This step should verify that the request can be executed, perform
* any authorization steps and update the in-memory cache.
-
+ *
* This step does not persist the changes to the database.
*
+ * To coders and reviewers, CAUTION: Do NOT bring external dependencies into
this method, doing so could potentially
+ * cause divergence in OM DB states in HA. If you have to, be extremely
careful.
+ * e.g. Do NOT invoke ACL check inside validateAndUpdateCache, which can use
Ranger plugin that relies on external DB.
Review Comment:
[nitpick] The documentation could be more precise about what constitutes
'external dependencies'. Consider clarifying that this refers to dependencies
on external systems like databases, web services, or file systems that might
not be consistently available across all HA nodes.
```suggestion
* To coders and reviewers, CAUTION: Do NOT bring external dependencies
into this method. Here, "external dependencies"
* refers to dependencies on external systems such as databases, web
services, or file systems that might not be
* consistently available across all HA nodes. Doing so could potentially
cause divergence in OM DB states in HA.
* If you have to, be extremely careful. For example, do NOT invoke ACL
check inside validateAndUpdateCache, which can
* use a Ranger plugin that relies on an external DB.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
