szetszwo opened a new pull request, #9505:
URL: https://github.com/apache/ozone/pull/9505

   ## What changes were proposed in this pull request?
   
   - In DefaultVolumeChoosingPolicy.chooseVolume(..), getCurrentUsage() is 
called multiple times so it can return different values. The biggest problem is 
the sorted(..) call. The code calls getCurrentUsage() in the comparator. The 
behavior is ill-defined for sorting changing values.
   
   - Another bug is that it has filtered the volumes > threshold first and then 
choose destVolume. The destVolume must also be > threshold, which is undesiable.
   
   ## What is the link to the Apache JIRA
   
   HDDS-14175
   
   ## How was this patch tested?
   
   By updating existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to