adoroszlai commented on a change in pull request #2266:
URL: https://github.com/apache/ozone/pull/2266#discussion_r635131065
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HAUtils.java
##########
@@ -413,47 +418,44 @@ public static File getMetaDir(DBDefinition definition,
return caCertPemList;
}
+ /**
+ * Retry for ever until CA list matches expected count.
+ * @param task - task to get CA list.
+ * @return CA list.
+ * @throws IOException
Review comment:
> it throws exception right?
Yes, but `@throws` also needs a description, to document when/why the
exception is thrown. The fact that it is thrown is already documented by the
`throws` part of the method declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
