lokeshj1703 commented on pull request #2230: URL: https://github.com/apache/ozone/pull/2230#issuecomment-846913805
If hypothetically you have 5 nodes with same utilisation then containsNode might not return true with the current change. Because binary search can return index of any node with same utilisation. `return index >= 0 && listToSearch.get(index).equals(node);` This logic would return false since the returned datanode might have a different id. Comparator would need to handle the case of same utilisation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
