fmorg-git commented on code in PR #9674: URL: https://github.com/apache/ozone/pull/9674#discussion_r2736205120
########## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/OSTSException.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.exception; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.SerializationFeature; +import com.fasterxml.jackson.dataformat.xml.XmlMapper; +import com.fasterxml.jackson.module.jaxb.JaxbAnnotationModule; +import javax.xml.bind.annotation.XmlAccessType; +import javax.xml.bind.annotation.XmlAccessorType; +import javax.xml.bind.annotation.XmlAttribute; +import javax.xml.bind.annotation.XmlElement; +import javax.xml.bind.annotation.XmlRootElement; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * This class represents exceptions raised from Ozone STS service. + */ +public class OSTSException extends OS3Exception { + private static final Logger LOG = LoggerFactory.getLogger(OSTSException.class); + private static final ObjectMapper MAPPER; + private static final String AWS_FAULT_NS = "http://webservices.amazon.com/AWSFault/2005-15-09";; Review Comment: From what I've read and past experience, it might not be a good idea to refer to the constants from the main logic in the tests. For example, suppose someone in future accidentally changes the value of `OSTSException.AWS_FAULT_NS` to some incorrect value, then if the tests refer to this constant, the tests will still pass, although the code in the main logic is incorrect. Having separate constants in the main logic and the tests gives a little more safety, because someone would have to change it incorrectly in multiple places for the tests to still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
