gardenia commented on code in PR #9363:
URL: https://github.com/apache/ozone/pull/9363#discussion_r2742443292
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -917,6 +917,68 @@ message SnapshotDiffJobProto {
optional double keysProcessedPct = 13;
}
+/**
+ * Per request type entities to hold arguments
+ * captured for CompletedRequestInfo
+ */
+message CreateVolumeOperationArgs {
Review Comment:
Good point. The intent of that approach was to have placeholder "args"
entities for each operation type we capture so that they could be filled out
later with any additional fields we want to capture for those operations (e.g.
hflush in the case of create file). However, having thought about your
feedback it occurs to me that protobuf allows us to add them later as the need
arises and therefore there is no value (unless I've misunderstood something) in
having placeholder empty ones at this point.
On that basis I have removed the empty argument messages and fields in the
"CompletedOperationInfo" message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
