ptlrs commented on code in PR #9718:
URL: https://github.com/apache/ozone/pull/9718#discussion_r2775676768
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -171,15 +173,14 @@ private synchronized void
connectToDatanode(DatanodeDetails dn)
OzoneConfigKeys.HDDS_CONTAINER_IPC_PORT_DEFAULT);
}
- if (LOG.isDebugEnabled()) {
- LOG.debug("Connecting to server : {}; nodes in pipeline : {}, ",
- dn, pipeline.getNodes());
- }
+ LOG.debug("Connecting to server : {}; nodes in pipeline : {}, ", dn,
pipeline.getNodes());
Review Comment:
If the concern is performance, then it's not required for SLF4J.
See https://www.slf4j.org/faq.html
>After evaluating whether to log or not, and only if the decision is
affirmative, will the logger implementation format the message and replace the
'{}' pair with the string value of entry. In other words, this form does not
incur the cost of parameter construction in case the log statement is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
