szetszwo commented on PR #9553: URL: https://github.com/apache/ozone/pull/9553#issuecomment-3863054731
> ... it completely depends on the transactions that happen together in the same double buffer ... @swamirishi , I agree. I mean that the current code does not have such transactions and we are not going to support such code. > ... improves the efficiency ... Let's talk about the correctness before talking about efficiency. As you mentioned in the description, the previously implementation (quoted below) indeed has a bug. So this change is very risky. > ... It also misses a case where a putKey/deleteKey can get added even though a deleteRange has been executed in the next batch after the following continuousDeleteRange batch. ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
