ptlrs commented on code in PR #341:
URL: https://github.com/apache/ozone-site/pull/341#discussion_r2819453330


##########
docs/07-system-internals/01-components/01-ozone-manager/01-disk-layout.md:
##########
@@ -1,8 +1,11 @@
 ---
+draft: true
 sidebar_label: Disk Layout
 ---
 # Ozone Manager Disk Layout
 
+**TODO:** Allow inclusion of the system internals folder by updating the 
excludes list in `docusaurus.config.js`.

Review Comment:
   Fixed



##########
docs/06-troubleshooting/01-startup.md:
##########
@@ -1,9 +1,11 @@
 ---
+draft: true
 sidebar_label: Startup
 ---
 
 # Troubleshooting Startup
 
 **TODO:** File a subtask under 
[HDDS-9860](https://issues.apache.org/jira/browse/HDDS-9860) and complete this 
page or section.
+**TODO:** Allow inclusion of the troubleshooting folder by updating the 
excludes list in `docusaurus.config.js`.

Review Comment:
   Fixed



##########
docs/08-developer-guide/03-test/01-unit-tests.md:
##########
@@ -1,6 +1,11 @@
+---
+draft: true
+---
+
 # Unit Tests
 
 **TODO:** File a subtask under 
[HDDS-9861](https://issues.apache.org/jira/browse/HDDS-9861) and complete this 
page or section.
+**TODO:** Uncomment link to this page in 
docs/08-developer-guide/01-build/01-Maven.md

Review Comment:
   I agree we would benefit from the unit and integration test pages but let's 
leave it as is. The acceptance test section will be helpful to new developers. 



##########
docs/07-system-internals/01-components/01-ozone-manager/01-disk-layout.md:
##########
@@ -1,8 +1,11 @@
 ---
+draft: true

Review Comment:
   Yes, I think we should adopt the new SOP of marking under-development pages 
as `draft`. 
   
   This decouples the publishing intent of the section and the pages under 
them. Even if a section is published it could have under-development pages. 
   
   Also, we get a nice banner in the dev-environment about which pages are not 
ready for production. 



##########
docusaurus.config.js:
##########
@@ -135,6 +135,10 @@ const config = {
           sidebarPath: undefined,
           editUrl:
             'https://github.com/apache/ozone-site/tree/master',
+          exclude: [

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to