jojochuang commented on code in PR #9788:
URL: https://github.com/apache/ozone/pull/9788#discussion_r2825235708
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/defrag/SnapshotDefragService.java:
##########
@@ -684,6 +757,7 @@ public synchronized boolean triggerSnapshotDefragOnce()
throws IOException {
snapshotsDefraggedCount.getAndIncrement();
Review Comment:
snapshotMetrics.incNumSnapshotDefrag() and snapshotsDefraggedCount looks
functionally equivalent.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotInternalMetrics.java:
##########
@@ -51,6 +51,28 @@ public class OmSnapshotInternalMetrics {
@Metric("Total no. of snapshot move table keys failures")
private MutableCounterLong numSnapshotMoveTableKeysFails;
+ /*
+ * Snapshot defragmentation metrics since last restart.
+ */
+ @Metric("Total no. of snapshot defragmentation operations (full and
incremental)")
+ private MutableCounterLong numSnapshotDefrag;
+ @Metric("Total no. of snapshot defragmentation failures (full and
incremental)")
+ private MutableCounterLong numSnapshotDefragFails;
Review Comment:
numSnapshotDefragFails, numSnapshotFullDefragFails and
numSnapshotIncDefragFails no test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
