devabhishekpal commented on code in PR #9793:
URL: https://github.com/apache/ozone/pull/9793#discussion_r2867312789
##########
hadoop-hdds/docs/content/design/mpu-gc-optimization.md:
##########
@@ -97,15 +97,14 @@ Split MPU metadata into:
message MultipartPartInfo {
required string partName = 1;
required uint32 partNumber = 2;
- required string volumeName = 3;
- required string bucketName = 4;
- required string keyName = 5;
- required uint64 dataSize = 6;
- required uint64 modificationTime = 7;
- repeated KeyLocationList keyLocationList = 8;
- repeated hadoop.hdds.KeyValue metadata = 9;
- optional FileEncryptionInfoProto fileEncryptionInfo = 10;
- optional FileChecksumProto fileChecksum = 11;
+ repeated KeyLocationList keyLocationList = 6;
+ required uint64 dataSize = 7;
+ required uint64 modificationTime = 8;
+ required uint64 objectID = 9;
+ required uint64 updateID = 10;
+ repeated hadoop.hdds.KeyValue metadata = 11;
Review Comment:
Hmm going through the upload part [API
documentation](https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html)
it seems like the request is allowed to have some `x-amz-meta*` type metadata
/ headers
Example:
```
PUT /Key+?partNumber=PartNumber&uploadId=UploadId HTTP/1.1
Host: Bucket.s3.amazonaws.com
Content-Length: ContentLength
Content-MD5: ContentMD5
x-amz-sdk-checksum-algorithm: ChecksumAlgorithm
x-amz-checksum-crc32: ChecksumCRC32
x-amz-checksum-crc32c: ChecksumCRC32C
x-amz-checksum-crc64nvme: ChecksumCRC64NVME
x-amz-checksum-sha1: ChecksumSHA1
x-amz-checksum-sha256: ChecksumSHA256
x-amz-server-side-encryption-customer-algorithm: SSECustomerAlgorithm
x-amz-server-side-encryption-customer-key: SSECustomerKey
x-amz-server-side-encryption-customer-key-MD5: SSECustomerKeyMD5
x-amz-request-payer: RequestPayer
x-amz-expected-bucket-owner: ExpectedBucketOwner
Body
```
In our case this metadata field is also being used for other things like
tracking the open key entry for a given part in the open key table and also
storing the ETag for the part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
