ivandika3 commented on code in PR #9863:
URL: https://github.com/apache/ozone/pull/9863#discussion_r2882994077
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -299,8 +302,11 @@ public String getNamespace() {
}
}
+ scmServiceId = HddsUtils.getScmServiceId(conf);
+
reconfigurationHandler =
- new ReconfigurationHandler("DN", conf, this::checkAdminPrivilege)
+ new DatanodeReconfigurationHandler("DN", conf,
this::checkAdminPrivilege)
+ .registerPrefix(ConfUtils.addKeySuffixes(OZONE_SCM_ADDRESS_KEY,
true, scmServiceId))
Review Comment:
Yes, it should. Thanks, updated.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/ha/ConfUtils.java:
##########
@@ -48,8 +48,20 @@ public static String addSuffix(String key, String suffix) {
* Return configuration key of format key.suffix1.suffix2...suffixN.
*/
public static String addKeySuffixes(String key, String... suffixes) {
+ return addKeySuffixes(key, false, suffixes);
+ }
+
+ /**
+ * Return configuration key of format key.suffix1.suffix2...suffixN with the
option to
+ * add a trailing separator.
+ */
+ public static String addKeySuffixes(String key, boolean
withTrailingSeparator, String... suffixes) {
String keySuffix = concatSuffixes(suffixes);
- return addSuffix(key, keySuffix);
+ String suffix = addSuffix(key, keySuffix);
+ if (withTrailingSeparator) {
+ suffix = suffix.concat(".");
Review Comment:
Agreed, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
