szetszwo commented on code in PR #9878:
URL: https://github.com/apache/ozone/pull/9878#discussion_r2899477134
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ScmCodecFactory.java:
##########
@@ -42,8 +47,18 @@ public final class ScmCodecFactory {
private static Map<Class<?>, ScmCodec<?>> codecs = new HashMap<>();
static {
- codecs.put(com.google.protobuf.Message.class, new
ScmNonShadedGeneratedMessageCodec());
- codecs.put(Message.class, new ScmGeneratedMessageCodec());
+ codecs.put(ContainerID.class,
+ new ScmNonShadedGeneratedMessageCodec<>(ContainerID.parser()));
+ codecs.put(PipelineID.class,
+ new ScmNonShadedGeneratedMessageCodec<>(PipelineID.parser()));
+ codecs.put(Pipeline.class,
+ new ScmNonShadedGeneratedMessageCodec<>(Pipeline.parser()));
+ codecs.put(ContainerInfoProto.class,
+ new ScmNonShadedGeneratedMessageCodec<>(ContainerInfoProto.parser()));
+ codecs.put(DeletedBlocksTransaction.class,
+ new
ScmNonShadedGeneratedMessageCodec<>(DeletedBlocksTransaction.parser()));
+ codecs.put(DeletedBlocksTransactionSummary.class,
+ new
ScmNonShadedGeneratedMessageCodec<>(DeletedBlocksTransactionSummary.parser()));
Review Comment:
@Russole , I forgot to say we may use the getDefaultInstance() trick;
```java
putProto(ContainerID.getDefaultInstance());
putProto(PipelineID.getDefaultInstance());
putProto(Pipeline.getDefaultInstance());
putProto(ContainerInfoProto.getDefaultInstance());
putProto(DeletedBlocksTransaction.getDefaultInstance());
putProto(DeletedBlocksTransactionSummary.getDefaultInstance());
```
```java
static <T extends Message> void putProto(T proto) {
codecs.put(proto.getClass(), new
ScmNonShadedGeneratedMessageCodec<>(proto.getParserForType()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
