vyalamar opened a new pull request, #9891:
URL: https://github.com/apache/ozone/pull/9891

   ## Summary
   
   Add config-gated OM metrics around the snapshot-diff iterator path.
   
   This keeps the scope narrow to observability for the split-iterator 
follow-up:
   - count snapshot diff iterators opened
   - count snapshot diff iterators closed
   - count keys scanned through the iterator path
   
   The metrics are disabled by default via 
`ozone.om.snapshot.diff.iterator.metrics.enabled`.
   
   ## Problem
   
   The snapshot-diff split-iterator path is currently opaque operationally. 
When snapshot diff jobs are slow or expensive, OM does not expose whether the 
iterator path was exercised or how much scan work it performed.
   
   ## Solution
   
   Instrument `SnapshotDiffManager.addToObjectIdMap(...)` with three OM 
counters and gate them behind a config flag.
   
   This PR deliberately does not change cancellation behavior or iterator 
fallback behavior. Those should remain separate follow-up changes.
   
   ## Tests
   
   - Added focused `TestSnapshotDiffManager` coverage for metrics 
disabled/enabled behavior.
   - Verified the existing tombstone/object-id-map test continues to pass with 
metrics disabled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to