SaketaChalamchala commented on PR #9869: URL: https://github.com/apache/ozone/pull/9869#issuecomment-4034934544
Thanks for the review @sadanand48 , @smengcl and @jojochuang I addressed your comments and relevant copilot suggestions as well Additional updates: - [reverted the error log to an exception](https://github.com/apache/ozone/pull/9869/changes#diff-d5b0b24274c5d19e876dc2ffeb744d4965fa1a23ce727ac09b965f665573c18aR405) in cleanup so that it fails fast. - Throwing an exception when cleanup function returns false so that callers that do not check for `isLockAcquired()` do not proceed without the lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
