ChenSammi commented on code in PR #8843:
URL: https://github.com/apache/ozone/pull/8843#discussion_r2915835263
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java:
##########
@@ -163,9 +159,8 @@ protected StorageVolume(Builder<?> b) throws IOException {
this.conf = b.conf;
this.dnConf = conf.getObject(DatanodeConfiguration.class);
this.ioTestCount = dnConf.getVolumeIOTestCount();
- this.ioFailureTolerance = dnConf.getVolumeIOFailureTolerance();
- this.ioTestSlidingWindow = new LinkedList<>();
- this.currentIOFailureCount = new AtomicInteger(0);
+ this.ioTestSlidingWindow = new
SlidingWindow(dnConf.getVolumeIOFailureTolerance(),
Review Comment:
Thanks @ptlrs for this improvement. Time window based solution is better
than current accumulated count solution, volume has the chance to survive
through the temporary failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
