adoroszlai commented on code in PR #9911: URL: https://github.com/apache/ozone/pull/9911#discussion_r2929327478
########## README.md: ########## @@ -119,8 +119,10 @@ For more information, you can check the [Contribution guideline](./CONTRIBUTING. All contributions are welcome. - 1. Please open a [Jira](https://issues.apache.org/jira/projects/HDDS/issues) issue - 2. And create a pull request + 1. If you do not have an ASF Jira account yet, please follow the first-time contributor +instructions in the [Jira guideline](CONTRIBUTING.md#jira-guideline). + 2. Please open a [Jira](https://issues.apache.org/jira/projects/HDDS/issues) issue + 3. And create a pull request For more information, you can check the [Contribution guideline](./CONTRIBUTING.md) Review Comment: I feel this section is awkward. How about simply referring readers to `CONTRIBUTING.md` without mentioning Jira and pull requests? ``` All contributions are welcome. Please see the [Contribution guideline](./CONTRIBUTING.md) for details. ``` ########## CONTRIBUTING.md: ########## @@ -79,6 +79,9 @@ See more details in the [README](https://github.com/apache/ozone/blob/master/had ## Jira guideline +If you do not have an ASF Jira account yet, please request one from the official ASF self-service page: +[Request a Jira account](https://selfserve.apache.org/jira-account.html). Review Comment: For convenience we can pre-select `ozone` as the ASF project: ```suggestion [Request a Jira account](https://selfserve.apache.org/jira-account.html?project=ozone). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
