ChenSammi commented on code in PR #9904: URL: https://github.com/apache/ozone/pull/9904#discussion_r2958788299
########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ########## @@ -37,12 +38,15 @@ abstract class RDBStoreAbstractIterator<RAW> private final ManagedRocksIterator rocksDBIterator; private final RDBTable rocksDBTable; private Table.KeyValue<RAW, RAW> currentEntry; - // This is for schemas that use a fixed-length Review Comment: Please keep this comment. Is it relevant to the patch? It's not recommended to change anything irrelevant in the patch. ########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ########## @@ -37,12 +38,15 @@ abstract class RDBStoreAbstractIterator<RAW> private final ManagedRocksIterator rocksDBIterator; private final RDBTable rocksDBTable; private Table.KeyValue<RAW, RAW> currentEntry; - // This is for schemas that use a fixed-length Review Comment: Please keep this comment. Is it relevant? It's not recommended to change anything irrelevant in the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
