navinko commented on PR #9624: URL: https://github.com/apache/ozone/pull/9624#issuecomment-4091945450
> @navinko please check [compile error](https://github.com/navinko/ozone/actions/runs/20932431970/job/60148545888) Thanks @adoroszlai for reviewing . To resolve the conflict with latest upstream changes i suppose to accept most of upstream changes . I rebased the branch with the latest master and resolved all conflicts. Also updated the ParallelTableIteratorOperation constructor usage across all callers to match the current API and fix the compilation errors. The build is now passing locally and [CI](https://github.com/navinko/ozone/actions/runs/23296602841) is successful. After aligning with the latest upstream changes, I see that the current implementation already introduces batching with maxKeysInMemory and worker threads, which addresses the original concern around in-memory accumulation. Could you please advise if any additional improvements are still expected as part of HDDS-14400, or if the current upstream changes already cover the intended behavior? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
