ptlrs commented on code in PR #9947:
URL: https://github.com/apache/ozone/pull/9947#discussion_r2961944470


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -404,6 +407,17 @@ public class DatanodeConfiguration extends 
ReconfigurableConfig {
   )
   private Duration diskCheckTimeout = DISK_CHECK_TIMEOUT_DEFAULT;
 
+  @Config(key = DISK_CHECK_RETRY_GAP_KEY,
+      defaultValue = "1m",

Review Comment:
   No, we don't want a long time between two checks as the goal here is to 
ignore transient errors while opening RocksDb. 
   
   If the gap between two consecutive attempts at opening RocksDb is too long, 
it is no longer about transient errors. 
   
   Secondly, we can't have the time period between opening the RocksDb twice be 
15 minutes as it will fail the disk check timeout of 10 minutes. 
   
   In case of errors when opening the RocksDb, we ideally want the thread to 
sleep for a very short time, try to open the RocksDb a second time and if we 
still fail, mark it as an actual failure to open RocksDb.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to