errose28 commented on PR #9974: URL: https://github.com/apache/ozone/pull/9974#issuecomment-4145759807
Previously we did not need this because finalization blocked until at least one pipeline of three finalized datanodes was created, which could happen while SCM was in safemode. The interim code we have on the branch is now blocking SCM until all datanodes are finalized. The problem is that SCM does not know how many datanodes there are until it exits safemode, so the condition will give different results depending when it is run. Looking at this again, once we remove that blocking code we probably don't need this. We only need to make sure we do not advertise to the OM that it should finalize while SCM is in safemode. SCM itself can finalize and send finalize commands to datanodes while in safemode. Perhaps we should leave this as a draft or just close it for now, and revisit once the the blocking code is removed and we are looking at notifying OM to finalize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
