gardenia commented on code in PR #9364:
URL: https://github.com/apache/ozone/pull/9364#discussion_r3010661019
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyCreateResponseWithFSO.java:
##########
@@ -55,4 +57,14 @@ public OMKeyCreateResponseWithFSO(@Nonnull OMResponse
omResponse, @Nonnull
BucketLayout bucketLayout) {
super(omResponse, bucketLayout);
}
+
+ @Override
+ public Type getOperationType() {
+ return Type.CreateKey;
+ }
+
+ @Override
+ public OmCompletedRequestInfo.OperationArgs getCompletedRequestInfoArgs() {
Review Comment:
> We can keep the getCompletedRequestInfoArgs in OMKeyCreateResponse, and
remove the getCompletedRequestInfoArgs here, they are the same.
@ChenSammi thanks for this. I'm not sure you are correct on this point.
OMKeyCreateResponseWithFSO has a inheritance hierarchy of:
* OMFileCreateResponseWithFSO
* OMFileCreateResponse
* OMKeyCreateResponse
Therefore it inherits the implementation of getCompletedRequestInfoArgs from
OMFileCreateResponse (rather than OMKeyCreateResponse) and so to get a "NoArgs"
implementation it has to explicitly override it as such.
If you disagree then of course let me know. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
