spacemonkd commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016862184
##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
git config user.email "[email protected]"
- name: Run chart-releaser
- uses: ./.github/actions/chart-releaser-action
+ uses:
helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0
Review Comment:
Hi @adoroszlai, just a question.
Don't they have this present directly as a version instead of a hash?
`helm/[email protected]`
Even with the comments it is kind of odd to look at the hash and takes a
little to register.
If possible it might be good to shift to using the version notation instead
##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
git config user.email "[email protected]"
- name: Run chart-releaser
- uses: ./.github/actions/chart-releaser-action
+ uses:
helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0
Review Comment:
Hi @adoroszlai, just a question.
Don't they have this present directly as a version instead of a hash?
`helm/[email protected]`
Even with the comments it is kind of odd to look at the hash and takes a
little while to register.
If possible it might be good to shift to using the version notation instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
